linux-kernel - Re: [PATCH v5 0/2] gpio: sch: Interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFNG8+sdIj6Orbjq@smile.fi.intel.com>
Date:   Thu, 18 Mar 2021 14:26:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v5 0/2] gpio: sch: Interrupt support

On Wed, Mar 17, 2021 at 05:19:26PM +0200, Andy Shevchenko wrote:
> The series adds event support to the Intel GPIO SCH driver. The hardware
> routes all events through GPE0 GPIO event.
> 
> I validated this on Intel Minnowboard (v1).
> 
> If somebody has different hardware with the same GPIO controller, I would
> appreciate additional testing.

I've applied this to my review and testing queue, thanks!

> Changes in v5:
> - added missed IRQ acknowledge callback (hence kernel Oops)
> - rewrite patch 2 completely from SCI to GPE hook
> 
> Changes in v4 (https://lore.kernel.org/linux-gpio/20210316162613.87710-1-andriy.shevchenko@linux.intel.com/T/#u):
> - turned to GPIO core infrastructure of IRQ chip instantiation (Linus)
> - converted IRQ callbacks to use better APIs
> - use handle_bad_irq() as default handler and now I know why, see
>   eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2")
>     for the real example what happens if it's preset to something meaningful
> - fixed remove stage (we have to remove SCI handler, which wasn't done in v3)
> 
> Changes in v3 (https://lore.kernel.org/linux-gpio/cover.1574277614.git.jan.kiszka@siemens.com/T/#u):
> - split-up of the irq enabling patch as requested by Andy
> 
> Andy Shevchenko (1):
>   gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events
> 
> Jan Kiszka (1):
>   gpio: sch: Add edge event support
> 
>  drivers/gpio/gpio-sch.c | 196 ++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 188 insertions(+), 8 deletions(-)
> 
> -- 
> 2.30.2
> 

-- 
With Best Regards,
Andy Shevchenko