linux-kernel - RE: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <602d6d53962c4567bc1363e58b49c757@AcuMS.aculab.com>
Date:   Thu, 18 Mar 2021 13:38:41 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Valdis Klētnieks' 
        <valdis.kletnieks@...edu>
CC:     Kees Cook <keescook@...omium.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old
 gcc

From: Valdis Kletnieks
> Sent: 18 March 2021 11:56
> 
> On Thu, 18 Mar 2021 11:41:29 -0000, David Laight said:
> 
> > That gcc bug just implies you need a space after "xxx".
> > That is easily fixable in the sources.
> 
> It's not quite that simple.
> 
>    In file included from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/tm.h:27,
>                     from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/gcc-plugin.h:31,
>                     from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/plugin.h:23,
>                     from scripts/gcc-plugins/gcc-common.h:9,
>                     from scripts/gcc-plugins/latent_entropy_plugin.c:78:
> >> /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/config/elfos.h:102:21: warning: invalid suffix on
> literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
>        fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\
> 
> The problem isn't in a kernel source file...  
...

Could you pass -Wno-literal-suffix on plugin builds?

Might be less faff than changing the -std=xxx' parameter.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)