linux-kernel - Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa312971-cedd-38bf-ac5c-6f3d4ff2c208@huawei.com>
Date:   Thu, 18 Mar 2021 10:37:26 +0800
From:   "heying (H)" <heying24@...wei.com>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Daniel Axtens <dja@...ens.net>, <benh@...nel.crashing.org>,
        <paulus@...ba.org>, <npiggin@...il.com>,
        <akpm@...ux-foundation.org>, <aneesh.kumar@...ux.ibm.com>,
        <rppt@...nel.org>, <ardb@...nel.org>, <clg@...d.org>,
        <christophe.leroy@...roup.eu>
CC:     <johnny.chenyi@...wei.com>, <linuxppc-dev@...ts.ozlabs.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup
 warnings


在 2021/3/17 19:57, Michael Ellerman 写道:
> Daniel Axtens <dja@...ens.net> writes:
>> "heying (H)" <heying24@...wei.com> writes:
>>
>>> Thank you for your reply.
>>>
>>> 在 2021/3/17 11:04, Daniel Axtens 写道:
>>>> Hi He Ying,
>>>>
>>>> Thank you for this patch.
>>>>
>>>> I'm not sure what the precise rules for Fixes are, but I wonder if this
>>>> should have:
>>>>
>>>> Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses")
>>>> Fixes: f79643787e0a ("powerpc/64s: flush L1D on kernel entry")
>>> Is that necessary for warning cleanups? I thought 'Fixes' tags are
>>> needed only for
>>>
>>> bugfix patches. Can someone tell me whether I am right?
>> Yeah, I'm not sure either. Hopefully mpe will let us know.
> It's not necessary to add a Fixes tag for a patch like this, but you can
> add one if you think it's important that the fix gets backported.
>
> I don't think the cleanups in this case are that important, so I
> wouldn't bother with a Fixes tag.
Okay. That's a good explanation to me. Thanks.