linux-kernel - Re: [PATCH] drivers/video/fbdev:modify 0 to NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20f1664e-df4c-d085-cb25-1d05e8a793a3@embeddedor.com>
Date:   Wed, 17 Mar 2021 20:41:15 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     ChunyouTang <tangchunyou@....com>, gustavoars@...nel.org,
        sam@...nborg.org
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, tangchunyou@...ong.com
Subject: Re: [PATCH] drivers/video/fbdev:modify 0 to NULL



On 3/17/21 21:33, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@...ong.com>
> 
> modify 0 to NULL,info is a pointer,it should be
> 
> compared with NULL,not 0
> 
> Signed-off-by: tangchunyou <tangchunyou@...ong.com>
> ---
>  drivers/video/fbdev/offb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 4501e84..cd1042f 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
>  
>  	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
>  
> -	if (info == 0) {
> +	if (info == NULL) {

if (!info) is better.

--
Gustavo

>  		release_mem_region(res_start, res_size);
>  		return;
>  	}
>