linux-kernel - Re: [PATCH v2] smp: kernel/panic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d94077e7-8599-a3c1-af76-65e588ea8d33@huawei.com>
Date:   Thu, 18 Mar 2021 10:56:26 +0800
From:   "heying (H)" <heying24@...wei.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
CC:     Christophe Leroy <christophe.leroy@...roup.eu>,
        <frederic@...nel.org>, <paulmck@...nel.org>, <clg@...d.org>,
        <qais.yousef@....com>, <johnny.chenyi@...wei.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] smp: kernel/panic.c - silence warnings


在 2021/3/18 4:09, Ingo Molnar 写道:
> * Peter Zijlstra <peterz@...radead.org> wrote:
>
>> Now, the C people figured that distinction was useless and allowed
>> sloppiness. But I still think there's merrit to that. And as
>> mentioned earlier, it is consistent with variable declarations.
> Fully agreed, and my other point was that it's also consistent with
> the other existing externs were used *in the same header file*
> already.
>
> I.e. there's nothing more sloppy than mixing different styles within
> the same header. Checkpatch needs to be fixed or ignored here.

Thank you all for the reply!

There are already mixing different styles within linux/smp.h. I mean 
'extern' and

non 'extern' func declarations both exist in this header. Since two of 
you three

think that 'extern' is needed, I'll add it and resend my patch.


Thanks again.