linux-kernel - Re: [PATCHv5 1/7] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFOGh+KKYcp17aeB@epycbox.lan>
Date:   Thu, 18 Mar 2021 09:57:43 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Richard Gong <richard.gong@...ux.intel.com>, mdf@...nel.org,
        gregkh@...uxfoundation.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, Richard Gong <richard.gong@...el.com>
Subject: Re: [PATCHv5 1/7] firmware: stratix10-svc: reset
 COMMAND_RECONFIG_FLAG_PARTIAL to 0

On Mon, Feb 15, 2021 at 06:32:16AM -0800, Tom Rix wrote:
> 
> On 2/15/21 6:41 AM, Richard Gong wrote:
> > Hi Tom,
> >
> > On 2/13/21 9:44 AM, Tom Rix wrote:
> >>
> >> On 2/9/21 2:20 PM, richard.gong@...ux.intel.com wrote:
> >>> From: Richard Gong <richard.gong@...el.com>
> >>>
> >>> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> >>> aligns with the firmware settings.
> >>>
> >>> Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values")
> >>> Signed-off-by: Richard Gong <richard.gong@...el.com>
> >>> ---
> >>> v5: new add, add the missing standalone patch
> >>> ---
> >>>   include/linux/firmware/intel/stratix10-svc-client.h | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> >>> index a93d859..f843c6a 100644
> >>> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> >>> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> >>> @@ -56,7 +56,7 @@
> >>>    * COMMAND_RECONFIG_FLAG_PARTIAL:
> >>>    * Set to FPGA configuration type (full or partial).
> >>>    */
> >>> -#define COMMAND_RECONFIG_FLAG_PARTIAL    1
> >>> +#define COMMAND_RECONFIG_FLAG_PARTIAL    0
> >>
> >> Is this the stand alone fix split from v3's patch 1 ?
> >>
> >> https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/
> >> Yes, it is a stand-alone patch.
> 
> Thanks.
> 
> Reviewed-by: Tom Rix <trix@...hat.com>
> 
> >
> >> Tom
> >>
> >>>     /**
> >>>    * Timeout settings for service clients:
> >>
> > Regards,
> > Richard
> >
> 

Applied to fixes.

Thanks,
Moritz