linux-kernel - Re: Checkpatch still worries about include/asm/ ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMx-4p361gFewN61NEbrwTjVY9wZFg2i13VMZTUxiDJB=Q@mail.gmail.com>
Date:   Thu, 18 Mar 2021 18:03:11 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>
Cc:     Joe Perches <joe@...ches.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Checkpatch still worries about include/asm/ ?

On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@...il.com> wrote:
>
> Hello,
> include/asm/ got removed a long time back (probably v1.1.45).
> Checkpatch still worries about that:
>
> if ($realfile =~ m@...clude/asm/@) {
> ERROR("MODIFIED_INCLUDE_ASM",
> "do not modify files in include/asm, change architecture specific
> files in include/asm-<architecture>\n" . "$here$rawline\n");
> }
>
> Can we remove this check?
>

Wow, v1.1.45... that must have been taking quite some digging in the
ancient dirt to find that out.

I agree, let us remove that rule.

Thanks for the documentation effort on checkpatch.pl and cleaning up
obsolete rules while documenting.

Lukas