linux-kernel - Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210318170623.GA1961@ninjato>
Date:   Thu, 18 Mar 2021 18:06:23 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>
Cc:     paul@...pouillou.net, stable@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, sernia.zhou@...mail.com
Subject: Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
> error when I2C write operation.

Any write operation? I wonder then why nobody noticed before?

> -			while ((i2c_sta & JZ4780_I2C_STA_TFNF) &&
> -					(i2c->wt_len > 0)) {
> +			while ((i2c_sta & JZ4780_I2C_STA_TFNF) && (i2c->wt_len > 0)) {

This is a cosmetic change only IIUC. Shouldn't be in a bugfix.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)