linux-kernel - Re: [PATCH 06/11] block: drbd: drbd_main: Remove duplicate field initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a234A2WmPFJxXmf-n+J7TP3A=DyDWEr657zxaML7V9UWQ@mail.gmail.com>
Date:   Fri, 19 Mar 2021 15:56:19 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Philipp Reisner <philipp.reisner@...bit.com>,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        Jens Axboe <axboe@...nel.dk>, drbd-dev@...ts.linbit.com,
        linux-block <linux-block@...r.kernel.org>
Subject: Re: [PATCH 06/11] block: drbd: drbd_main: Remove duplicate field initialisation

On Fri, Mar 12, 2021 at 11:57 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> [P_RETRY_WRITE] is initialised more than once.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/block/drbd/drbd_main.c: In function ‘cmdname’:
>  drivers/block/drbd/drbd_main.c:3660:22: warning: initialized field overwritten [-Woverride-init]
>  drivers/block/drbd/drbd_main.c:3660:22: note: (near initialization for ‘cmdnames[44]’)
>
> Cc: Philipp Reisner <philipp.reisner@...bit.com>
> Cc: Lars Ellenberg <lars.ellenberg@...bit.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: drbd-dev@...ts.linbit.com
> Cc: linux-block@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Looks correct. I had actually posted a slightly different fix last year,
but either one addresses the warning:

https://lore.kernel.org/lkml/20201026215043.3893318-1-arnd@kernel.org/

         Arnd