linux-kernel - Re: [PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFS9L6vmwcR/z7hs@google.com>
Date:   Sat, 20 Mar 2021 00:03:11 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Yafang Shao <laoar.shao@...il.com>
Cc:     pmladek@...e.com, willy@...radead.org,
        andriy.shevchenko@...ux.intel.com, david@...hat.com,
        linmiaohe@...wei.com, vbabka@...e.cz, cl@...ux.com,
        penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, rostedt@...dmis.org,
        sergey.senozhatsky@...il.com, joe@...ches.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, lkp@...el.com
Subject: Re: [PATCH v6 resend 0/3] mm, vsprintf: dump full information of
 page flags in pGp

On (21/03/19 18:12), Yafang Shao wrote:
> 
> The existed pGp shows the names of page flags only, rather than the full
> information including section, node, zone, last cpuipid and kasan tag.
> While it is not easy to parse these information manually because there
> are so many flavors. We'd better interpret them in printf.
> 
> To be compitable with the existed format of pGp, the new introduced ones
> also use '|' as the separator, then the user tools parsing pGp won't
> need to make change, suggested by Matthew. The new added information is
> tracked onto the end of the existed one, e.g.
> [ 8838.835456] Slab 0x000000002828b78a objects=33 used=3 fp=0x00000000d04efc88 flags=0x17ffffc0010200(slab|head|node=0|zone=2|lastcpupid=0x1fffff)
> 
> The documentation and test cases are also updated. The result of the
> test cases as follows,
> [68599.816764] test_printf: loaded.
> [68599.819068] test_printf: all 388 tests passed
> [68599.830367] test_printf: unloaded.
> 
> This patchset also includes some code cleanup in mm/slub.c.

The series looks good to me. FWIW,

Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>