linux-kernel - Re: [PATCH] spi: stm32: Fix use-after-free on unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161617166734.9851.4969692619964809885.b4-ty@kernel.org>
Date:   Fri, 19 Mar 2021 16:37:03 +0000
From:   Mark Brown <broonie@...nel.org>
To:     amelie.delaunay@...s.st.com,
        Alain Volmat <alain.volmat@...s.st.com>
Cc:     Mark Brown <broonie@...nel.org>, mcoquelin.stm32@...il.com,
        fabrice.gasnier@...s.st.com, alexandre.torgue@...s.st.com,
        linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
        antonio.borneo@...s.st.com,
        linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: stm32: Fix use-after-free on unbind

On Thu, 18 Mar 2021 08:24:50 +0100, Alain Volmat wrote:
> stm32_spi_remove() accesses the driver's private data after calling
> spi_unregister_master() even though that function releases the last
> reference on the spi_master and thereby frees the private data.
> 
> Fix by switching over to the new devm_spi_alloc_master() helper which
> keeps the private data accessible until the driver has unbound.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: stm32: Fix use-after-free on unbind
      commit: 79c6246ae8793448c05da86a4c82298eed8549b0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark