linux-kernel - Re: [PATCH] net/rds: correct socket tunable error in rds_tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210319164823.GA1124392@casper.infradead.org>
Date:   Fri, 19 Mar 2021 16:48:23 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     William Kucharski <william.kucharski@...cle.com>
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com, linux-kernel@...r.kernel.org,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()

On Wed, Mar 17, 2021 at 08:52:04AM -0600, William Kucharski wrote:
> Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
> instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
> 
> Signed-off-by: William Kucharski <william.kucharski@...cle.com>

Looks like a pretty clear copy-n-paste error.  I think Coverity have
started looking for issues like this?

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Also, maybe,

Fixes: c6a58ffed536 ("RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket")