linux-kernel - Re: [PATCH] HID: ft260: fix an error message in ft260_i2c_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210319165605.GB1940@michael-VirtualBox>
Date:   Fri, 19 Mar 2021 18:56:05 +0200
From:   Michael Zaidman <michael.zaidman@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Jiri Kosina <jikos@...nel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-i2c@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Michael Zaidman <michael.zaidman@...il.com>
Subject: Re: [PATCH] HID: ft260: fix an error message in
 ft260_i2c_write_read()

On Fri, Mar 19, 2021 at 02:26:43PM +0100, Jiri Kosina wrote:
> On Thu, 18 Mar 2021, Dan Carpenter wrote:
> 
> > The "len" variable is uninitialize.
> > 
> > Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> >  drivers/hid/hid-ft260.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c
> > index 047aa85a7c83..a5751607ce24 100644
> > --- a/drivers/hid/hid-ft260.c
> > +++ b/drivers/hid/hid-ft260.c
> > @@ -512,7 +512,8 @@ static int ft260_i2c_write_read(struct ft260_device *dev, struct i2c_msg *msgs)
> >  	struct hid_device *hdev = dev->hdev;
> >  
> >  	if (msgs[0].len > 2) {
> > -		hid_err(hdev, "%s: unsupported wr len: %d\n", __func__, len);
> > +		hid_err(hdev, "%s: unsupported wr len: %d\n", __func__,
> > +			msgs[0].len);
> >  		return -EOPNOTSUPP;
> >  	}

Dan, thanks for that quick fix.

> Applied, thanks Dan.
> -- 
> Jiri Kosina

Jiri, thank you for applying it.