linux-kernel - Re: [PATCH v3 4/7] ASoC: codecs: wcd938x: add basic controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe430019-783c-d5ba-e79d-d48944c01f04@linux.intel.com>
Date:   Fri, 19 Mar 2021 11:03:09 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        broonie@...nel.org
Cc:     robh@...nel.org, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        lgirdwood@...il.com
Subject: Re: [PATCH v3 4/7] ASoC: codecs: wcd938x: add basic controls


> +static int wcd938x_ear_pa_put_gain(struct snd_kcontrol *kcontrol,
> +				   struct snd_ctl_elem_value *ucontrol)
> +{
> +	struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
> +	struct wcd938x_sdw_priv *wcd = snd_soc_component_get_drvdata(component);
> +	struct wcd938x_priv *wcd938x = wcd->wcd938x;
> +
> +	if (wcd938x->comp1_enable) {
> +		dev_err(component->dev, "Can not set EAR PA Gain, compander1 is enabled\n");
> +		return -EINVAL;
> +	}
> +
> +	snd_soc_component_write_field(component, WCD938X_ANA_EAR_COMPANDER_CTL,
> +				      WCD938X_EAR_GAIN_MASK,
> +				      ucontrol->value.integer.value[0]);
> +
> +	return 0;

that goes back to my other comments, the earpiece is connected to the RX 
interface, so what component would be used to set the gain here? the TX 
one? But what tells you this component is active and ready to support 
commands?