linux-kernel - RE: Re: [PATCH] scsi: ufs: Add selector to ufshcd_query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210319025121epcms2p54274eddaa64ae4d0868424df3dac11b2@epcms2p5>
Date:   Fri, 19 Mar 2021 11:51:21 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Daejun Park <daejun7.park@...sung.com>
CC:     "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "huobean@...il.com" <huobean@...il.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        JinHwan Park <jh.i.park@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: RE: Re: [PATCH] scsi: ufs: Add selector to ufshcd_query_flag* APIs

Hi Martin

> 
>Daejun,
> 
>> Unlike other query APIs in UFS, ufshcd_query_flag has a fixed selector
>> as 0. This patch allows ufshcd_query_flag API to choose selector value
>> by parameter.
> 
>I don't see any users of the added parameter. Am I missing something?

The JEDEC standard describes it as follows:
The selector field may be needed to further identify a particular element of a flag.

Other cannot used it because it is fixed as zero in the API.

Thanks,
Daejun

The selector field may be needed to further identify a particular element of a flag. Selector field is not
2218 used in this version of the standard and its value shall be zero.
> 
>-- 
>Martin K. Petersen        Oracle Linux Engineering
> 
> 
>