linux-kernel - Re: [PATCH V2] Trivial typo fix and sentence construction for better readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210319200706.2dlq33ii33gyakyf@brm-x62-17.us.oracle.com>
Date:   Fri, 19 Mar 2021 14:07:06 -0600
From:   Tom Saeger <tom.saeger@...cle.com>
To:     Randy Dunlap <rdunlap@...badil.infradead.org>
Cc:     Bhaskar Chowdhury <unixbhaskar@...il.com>, axboe@...nel.dk,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Trivial typo fix and sentence construction for better
 readability

On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote:
> 
> Hm, needs some spacing fixes IMO. See below.
> 
> 
> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
> 
> > 
> > s/funtion/functions/
> > 
> > Plus the sentence reconstructed for better readability.
> > 
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> > ---
> > Changes from V1:
> >  Randy's suggestions incorporated.
> > 
> > block/blk-mq-tag.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> > index 9c92053e704d..c2bef283db63 100644
> > --- a/block/blk-mq-tag.c
> > +++ b/block/blk-mq-tag.c
> > @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
> > }
> > 
> > /**
> > - * blk_mq_tagset_wait_completed_request - wait until all completed req's
> > - * complete funtion is run

completion function

That's my read of it.

--Tom

> > + * blk_mq_tagset_wait_completed_request - wait until all the  req's
> 
>                                                             the req's
> 
> > + *  functions completed their run
> 
> and more indentation + wording on that line above:
>  *        functions have completed their run
> 
> >  * @tagset:	Tag set to drain completed request
> >  *
> >  * Note: This function has to be run after all IO queues are shutdown
> > --
> 
> Thanks.