[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YFQg4RdOWUABOlPN@rocinante>
Date: Fri, 19 Mar 2021 04:56:17 +0100
From: Krzysztof WilczyĆski <kw@...ux.com>
To: Greentime Hu <greentime.hu@...ive.com>
Cc: paul.walmsley@...ive.com, hes@...ive.com, erik.danie@...ive.com,
zong.li@...ive.com, bhelgaas@...gle.com, robh+dt@...nel.org,
palmer@...belt.com, aou@...s.berkeley.edu, mturquette@...libre.com,
sboyd@...nel.org, lorenzo.pieralisi@....com,
p.zabel@...gutronix.de, alex.dewar90@...il.com,
khilman@...libre.com, hayashi.kunihiko@...ionext.com,
vidyas@...dia.com, jh80.chung@...sung.com,
linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, helgaas@...nel.org
Subject: Re: [PATCH v2 4/6] dt-bindings: PCI: Add SiFive FU740 PCIe host
controller
Hi,
Thank you for sending the patches over!
A few nitpicks.
> +title: SiFive fu740 PCIe host controller
> +
> +description:
> + SiFive fu740 PCIe host controller is based on the Synopsys DesignWare
> + PCI core. It shares common features with the PCIe DesignWare core and
> + inherits common properties defined in
> + Documentation/devicetree/bindings/pci/designware-pcie.txt.
[...]
In the above title and description it would be "FU740" to keep this
consistent with everything else.
Also, as this is a YAML file, a multi-line description might be better
expressed as "description: |" or "description: |+", of course it depends
on whether you would like or not to preserve line endings.
[...]
> + dma-coherent:
> + description: Indicates that the PCIe IP block can ensure the coherency
> +
> + bus-range:
> + description: Range of bus numbers associated with this controller.
[...]
> + resets:
> + description: A phandle to the PCIe power up reset line
> +
> + pwren-gpios:
> + description: Should specify the GPIO for controlling the PCI bus device power on
> +
> + perstn-gpios:
> + description: Should specify the GPIO for controlling the PCI bus device reset
[...]
All the above descriptions should end with a period, so that we keep
things consistent throughout.
Krzysztof
Powered by blists - more mailing lists