linux-kernel - Re: [PATCH] cifsd: Fix a use after free on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFQrzC0PA32D8Ar3@jagdpanzerIV.localdomain>
Date:   Fri, 19 Mar 2021 13:42:52 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        Hyunchul Lee <hyc.lee@...il.com>,
        Steve French <stfrench@...rosoft.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        linux-kernel@...r.kernel.org, linux-cifs@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] cifsd: Fix a use after free on error path

On (21/03/18 16:12), Dan Carpenter wrote:
> The ksmbd_free_work_struct() frees "work" so we need to swap the order
> of these two function calls to avoid a use after free.
> 
> Fixes: cabcebc31de4 ("cifsd: introduce SMB3 kernel server")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks.

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss