linux-kernel - Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01c9f635-7b2b-fc9c-3cf9-6d7f425d683e@foss.st.com>
Date:   Fri, 19 Mar 2021 09:38:39 +0100
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     dillon min <dillon.minfei@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <linux@...linux.org.uk>, Vladimir Murzin <vladimir.murzin@....com>,
        <afzal.mohd.ma@...il.com>, <gregkh@...uxfoundation.org>,
        <erwan.leray@...com>, <erwan.leray@...s.st.com>,
        <linux-serial@...r.kernel.org>, <lkp@...el.com>
Subject: Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle
 'bluetooth' to fix dtbs_check warrning

Hi Dillon

On 3/19/21 5:28 AM, dillon min wrote:
> No changes, Just loop lkp in.
> 
> 
> Hi lkp,
> 
> Sorry for the late reply, thanks for your report.
> This patch is to fix the build warning message.
> 
> Thanks.
> Regards
> 
> On Mon, Mar 15, 2021 at 5:45 PM <dillon.minfei@...il.com> wrote:
>>
>> From: dillon min <dillon.minfei@...il.com>
>>
>> when run make dtbs_check with 'bluetoothi brcm,bcm43438-bt'
>> dts enabled on stm32h7, there is a warrning popup:
>>
>>>> arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@...04800: 'bluetooth'
>>     does not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> to make dtbs_check happy, so add a phandle bluetooth
>>
>> Fixes: 500cdb23d608 ("ARM: dts: stm32: Add STM32H743 MCU and STM32H743i-EVAL board")
>> Signed-off-by: dillon min <dillon.minfei@...il.com>
>> Reported-by: kernel test robot <lkp@...el.com>
>> ---
>>   Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> index 8631678283f9..5e674840e62d 100644
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -50,6 +50,11 @@ properties:
>>       minItems: 1
>>       maxItems: 2
>>
>> +  bluetooth:
>> +    type: object
>> +    description: |
>> +      phandles to the usart controller and bluetooth
>> +

Do we really need to add this "generic" property here ? You could test 
without the "AditionalProperties:False".

Regards
Alex


>>   # cts-gpios and rts-gpios properties can be used instead of 'uart-has-rtscts'
>>   # or 'st,hw-flow-ctrl' (deprecated) for making use of any gpio pins for flow
>>   # control instead of dedicated pins.
>> --
>> 1.9.1
>>