linux-kernel - Re: [PATCH v2 05/14] objtool: Per arch retpoline naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFRpz5Ci+jWEWOZl@hirez.programming.kicks-ass.net>
Date:   Fri, 19 Mar 2021 10:07:27 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, jgross@...e.com, mbenes@...e.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/14] objtool: Per arch retpoline naming

On Thu, Mar 18, 2021 at 09:38:14PM -0500, Josh Poimboeuf wrote:
> On Thu, Mar 18, 2021 at 06:11:08PM +0100, Peter Zijlstra wrote:
> > @@ -872,7 +877,7 @@ static int add_jump_destinations(struct
> >  		} else if (reloc->sym->type == STT_SECTION) {
> >  			dest_sec = reloc->sym->sec;
> >  			dest_off = arch_dest_reloc_offset(reloc->addend);
> > -		} else if (!strncmp(reloc->sym->name, "__x86_indirect_thunk_", 21)) {
> > +		} else if (arch_is_retpoline(reloc->sym)) {
> >  			/*
> >  			 * Retpoline jumps are really dynamic jumps in
> >  			 * disguise, so convert them accordingly.
> 
> There's another one in add_call_destinations().

Bah, I'm sure I converted all of them at some point, must've lost a hunk
somewhere along the way. Fixed!