linux-kernel - Re: [PATCH] Updated locking documentation for journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210319103701.GC4910@quack2.suse.cz>
Date:   Fri, 19 Mar 2021 11:37:01 +0100
From:   Jan Kara <jack@...e.cz>
To:     Alexander Lochmann <alexander.lochmann@...dortmund.de>
Cc:     jack@...e.cz, Horst Schirmeier <horst.schirmeier@...dortmund.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Updated locking documentation for journal_head

On Fri 19-03-21 10:18:17, Alexander Lochmann wrote:
> LockDoc's results show that t_list_lock has been
> replaced by j_list_lock for b_next_transaction,
> b_tnext, and b_tprev.
> We, therefore, updated the documentation
> accordingly.
> 
> Signed-off-by: Alexander Lochmann <alexander.lochmann@...dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@...dortmund.de>

Yeah, I think that was a typo since the beginning. Thanks for the fix. Feel
free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/journal-head.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 75bc56109031..d68ae72784eb 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -80,13 +80,13 @@ struct journal_head {
>  	 * Pointer to the running compound transaction which is currently
>  	 * modifying the buffer's metadata, if there was already a transaction
>  	 * committing it when the new transaction touched it.
> -	 * [t_list_lock] [b_state_lock]
> +	 * [j_list_lock] [b_state_lock]
>  	 */
>  	transaction_t *b_next_transaction;
>  
>  	/*
>  	 * Doubly-linked list of buffers on a transaction's data, metadata or
> -	 * forget queue. [t_list_lock] [b_state_lock]
> +	 * forget queue. [j_list_lock] [b_state_lock]
>  	 */
>  	struct journal_head *b_tnext, *b_tprev;
>  
> -- 
> 2.20.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR