[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5fdd232b-6392-8684-2be2-6ff4375b7a8c@linaro.org>
Date: Fri, 19 Mar 2021 12:27:44 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Robert Foss <robert.foss@...aro.org>, amitk@...nel.org,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
rui.zhang@...el.com, Rob Herring <robh+dt@...nel.org>,
linux-pm@...r.kernel.org, MSM <linux-arm-msm@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Vinod Koul <vinod.koul@...aro.org>
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sm8350: Add thermal zones and
throttling support
On 19/03/2021 12:24, Robert Foss wrote:
> On Fri, 19 Mar 2021 at 11:49, Robert Foss <robert.foss@...aro.org> wrote:
>>
>> sm8350 has 29 thermal sensors split across two tsens controllers. Add
>> the thermal zones to expose them and wireup the cpus to throttle their
>> frequencies on crossing passive temperature thresholds.
>>
>> Signed-off-by: Robert Foss <robert.foss@...aro.org>
>> ---
[ ... ]
>> + };
>> +
>> + // TODO: What is the NSP subsystem?
>
> This comment should not have been included, will remove in v2
Please trim when replying to a large patch file.
[ ... ]
>> + trips {
>> + nspss1_alert0: trip-point0 {
>> + temperature = <90000>;
>> + hysteresis = <1000>;
>> + type = "hot";
>> + };
>> + };
>> + };
>> +
>> + // TODO: What is the NSP subsystem?
>
> This comment should not have been included, will remove in v2
[ ... ]
>> + trips {
>> + nspss2_alert0: trip-point0 {
>> + temperature = <90000>;
>> + hysteresis = <1000>;
>> + type = "hot";
>> + };
>> + };
>> + };
>> +
>> + // TODO: What is the NSP subsystem?
>
> This comment should not have been included, will remove in v2
>
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists