linux-kernel - Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h

Open Source and information security mailing list archives

Date:   Fri, 19 Mar 2021 20:38:45 +0800
From:   Baoquan He <bhe@...hat.com>
To:     menglong8.dong@...il.com
Cc:     dyoung@...hat.com, vgoyal@...hat.com, kexec@...ts.infradead.org,
        linux-kernel@...r.kernel.org, tiantao6@...ilicon.com,
        Zhang Yunkai <zhang.yunkai@....com.cn>
Subject: Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h

On 03/13/21 at 02:35am, menglong8.dong@...il.com wrote:
> From: Zhang Yunkai <zhang.yunkai@....com.cn>
> 
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> It is also included in the 8th line.

Tian Tao posted one to address the same issue, his log is better. Please
update with below to repost.

linux/pgtable.h is included more than once, Remove the one that isn't
necessary.

> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@....com.cn>
> ---
>  include/linux/crash_dump.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b718dbe..6bd8a33cb740 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
>  #include <linux/pgtable.h>
>  #include <uapi/linux/vmcore.h>
>  
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
>  #ifdef CONFIG_CRASH_DUMP
>  #define ELFCORE_ADDR_MAX	(-1ULL)
>  #define ELFCORE_ADDR_ERR	(-2ULL)
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives