linux-kernel - Re: [PATCH 5.11 12/31] gpiolib: Read "gpio-line-names" from a firmware node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1950c577-51e6-34f1-a4cd-ea46c736fc30@denx.de>
Date:   Fri, 19 Mar 2021 13:45:07 +0100
From:   Marek Vasut <marex@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Roman Guskov <rguskov@...electronics.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.11 12/31] gpiolib: Read "gpio-line-names" from a
 firmware node

On 3/19/21 1:36 PM, Greg Kroah-Hartman wrote:
> On Fri, Mar 19, 2021 at 01:27:23PM +0100, Marek Vasut wrote:
>> On 3/19/21 1:19 PM, Greg Kroah-Hartman wrote:
>>> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>>
>>> [ Upstream commit b41ba2ec54a70908067034f139aa23d0dd2985ce ]
>>>
>>> On STM32MP1, the GPIO banks are subnodes of pin-controller@...02000,
>>> see arch/arm/boot/dts/stm32mp151.dtsi. The driver for
>>> pin-controller@...02000 is in drivers/pinctrl/stm32/pinctrl-stm32.c
>>> and iterates over all of its DT subnodes when registering each GPIO
>>> bank gpiochip. Each gpiochip has:
>>>
>>>     - gpio_chip.parent = dev,
>>>       where dev is the device node of the pin controller
>>>     - gpio_chip.of_node = np,
>>>       which is the OF node of the GPIO bank
>>>
>>> Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node),
>>> i.e. pin-controller@...02000 != pin-controller@...02000/gpio@...0*000.
>>>
>>> The original code behaved correctly, as it extracted the "gpio-line-names"
>>> from of_fwnode_handle(chip.of_node) = pin-controller@...02000/gpio@...0*000.
>>>
>>> To achieve the same behaviour, read property from the firmware node.
>>
>> I think we agreed to drop this one for now before, see
>> [PATCH 5.10 081/290] gpiolib: Read "gpio-line-names" from a firmware node
>> Message-ID: <YFIo3A14Fb4Hty4O@...ah.com>
> 
> Sorry, now dropped.  Again.

No worries, good thing we have the review process in place :)