linux-kernel - Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210319131011.GA3372@lst.de>
Date:   Fri, 19 Mar 2021 14:10:11 +0100
From:   Christoph Hellwig <hch@....de>
To:     Ricardo Ribalda <ribalda@...omium.org>
Cc:     Christoph Hellwig <hch@....de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Tomasz Figa <tfiga@...omium.org>,
        Sergey Senozhatsky <senozhatsky@...gle.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        "list@....net:IOMMU DRIVERS <iommu@...ts.linux-foundation.org>, Joerg
        Roedel <joro@...tes.org>," <iommu@...ts.linux-foundation.org>,
        Robin Murphy <robin.murphy@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote:
> > +                                   uvc_urb->sgt,
> > +                                   uvc_stream_dir(uvc_urb->stream));
> > +       return usb_submit_urb(uvc_urb->urb, GFP_KERNEL);
> > +}
> 
> We should have mem_flags instead of GFP_KERNEL here
> 
> 
> Is it too late to fix it in your tree? Do I need to send a patch to fix it?

As far as I know we don't have anything that has pulled in the tree yet,
so I can just fold the fix in.