linux-kernel - Re: [PATCH] dt-bindings: More cleanup of standard unit properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210320135101.64c5c4e1@jic23-huawei>
Date:   Sat, 20 Mar 2021 13:51:01 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luca Ceresoli <luca@...aceresoli.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Kevin Tsai <ktsai@...ellamicro.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Mark Brown <broonie@...nel.org>, linux-iio@...r.kernel.org,
        linux-input@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: More cleanup of standard unit properties

On Tue, 16 Mar 2021 13:48:24 -0600
Rob Herring <robh@...nel.org> wrote:

> Properties with standard unit suffixes already have a type and don't need
> type references. Fix a few more cases which have gotten added.
> 
> Cc: Luca Ceresoli <luca@...aceresoli.net>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Kevin Tsai <ktsai@...ellamicro.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: linux-iio@...r.kernel.org
> Cc: linux-input@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  Documentation/devicetree/bindings/iio/light/capella,cm3605.yaml | 1 -
>  Documentation/devicetree/bindings/input/input.yaml              | 1 -
>  Documentation/devicetree/bindings/power/supply/bq256xx.yaml     | 1 -
>  Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml   | 2 --
>  .../devicetree/bindings/regulator/qcom-labibb-regulator.yaml    | 1 -
>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml          | 1 -
>  6 files changed, 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm3605.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm3605.yaml
> index 27972938b60d..c63b79c3351b 100644
> --- a/Documentation/devicetree/bindings/iio/light/capella,cm3605.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/capella,cm3605.yaml
> @@ -48,7 +48,6 @@ properties:
>    vdd-supply: true
>  
>    capella,aset-resistance-ohms:
> -    $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [50000, 100000, 300000, 600000]
>      description: >
>        Sensitivity calibration resistance. Note that calibration curves
> diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> index ab407f266bef..3fc37478c0c0 100644
> --- a/Documentation/devicetree/bindings/input/input.yaml
> +++ b/Documentation/devicetree/bindings/input/input.yaml
> @@ -32,6 +32,5 @@ properties:
>        Duration in seconds which the key should be kept pressed for device to
>        power off automatically. Device with key pressed shutdown feature can
>        specify this property.
> -    $ref: /schemas/types.yaml#/definitions/uint32
>  
>  additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> index 18b54783e11a..92ec7ed25668 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> @@ -39,7 +39,6 @@ properties:
>      maxItems: 1
>  
>    ti,watchdog-timeout-ms:
> -    $ref: /schemas/types.yaml#/definitions/uint32
>      default: 0
>      description: |
>        Watchdog timer in ms. 0 (default) disables the watchdog
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> index 1f88c9e013f4..6d7aa97a6475 100644
> --- a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> @@ -29,12 +29,10 @@ properties:
>      description: I2C address of the charger.
>  
>    lltc,rsnsb-micro-ohms:
> -    $ref: /schemas/types.yaml#/definitions/uint32
>      description: Battery sense resistor in microohm.
>      minimum: 1000
>  
>    lltc,rsnsi-micro-ohms:
> -    $ref: /schemas/types.yaml#/definitions/uint32
>      description: Input current sense resistor in microohm.
>      minimum: 1000
>  
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> index cf784bd1f5e5..1ddc1efd19e2 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> @@ -23,7 +23,6 @@ properties:
>  
>      properties:
>        qcom,soft-start-us:
> -        $ref: /schemas/types.yaml#/definitions/uint32
>          description: Regulator soft start time in microseconds.
>          enum: [200, 400, 600, 800]
>          default: 200
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> index 7cd364430573..95a728f4d333 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> @@ -78,7 +78,6 @@ patternProperties:
>            also known as absolute calibration.
>  
>        qcom,hw-settle-time-us:
> -        $ref: /schemas/types.yaml#/definitions/uint32
>          description: Time between AMUX getting configured and the ADC starting conversion.
>          enum: [15, 100, 200, 300, 400, 500, 600, 700, 1000, 2000, 4000, 8000, 16000, 32000, 64000, 128000]
>