linux-kernel - Re: [PATCH 3/6] sched: prctl() cookie manipulation for core scheduling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210320155127.GA4746@worktop.programming.kicks-ass.net>
Date:   Sat, 20 Mar 2021 16:51:27 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Joel Fernandes (Google)" <joel@...lfernandes.org>
Cc:     Nishanth Aravamudan <naravamudan@...italocean.com>,
        Julien Desfossez <jdesfossez@...italocean.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Vineeth Pillai <viremana@...ux.microsoft.com>,
        Aaron Lu <aaron.lwe@...il.com>,
        Aubrey Li <aubrey.intel@...il.com>, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        torvalds@...ux-foundation.org, fweisbec@...il.com,
        keescook@...omium.org, Phil Auld <pauld@...hat.com>,
        Valentin Schneider <valentin.schneider@....com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
        Paolo Bonzini <pbonzini@...hat.com>, vineeth@...byteword.org,
        Chen Yu <yu.c.chen@...el.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Agata Gruza <agata.gruza@...el.com>,
        Antonio Gomez Iglesias <antonio.gomez.iglesias@...el.com>,
        graf@...zon.com, konrad.wilk@...cle.com, dfaggioli@...e.com,
        rostedt@...dmis.org, benbjiang@...cent.com,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        James.Bottomley@...senpartnership.com, OWeisse@...ch.edu,
        Dhaval Giani <dhaval.giani@...cle.com>, chris.hyser@...cle.com,
        Josh Don <joshdon@...gle.com>, Hao Luo <haoluo@...gle.com>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH 3/6] sched: prctl() cookie manipulation for core
 scheduling.

On Fri, Mar 19, 2021 at 04:32:50PM -0400, Joel Fernandes (Google) wrote:

>  include/linux/sched.h            |   7 ++
>  include/linux/sched/task.h       |   4 +-
>  include/uapi/linux/prctl.h       |   7 ++
>  kernel/sched/core.c              |  11 +-
>  kernel/sched/coretag.c           | 197 +++++++++++++++++++++++++++++--
>  kernel/sched/sched.h             |   2 +
>  kernel/sys.c                     |   7 ++
>  tools/include/uapi/linux/prctl.h |   7 ++
>  8 files changed, 230 insertions(+), 12 deletions(-)
> 

> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2e3024a6f6e1..a62e8ad5ce58 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4654,11 +4654,17 @@ unsigned long nr_iowait(void)
>   * sched_exec - execve() is a valuable balancing opportunity, because at
>   * this point the task has the smallest effective memory and cache footprint.
>   */
> -void sched_exec(void)
> +int sched_exec(void)
>  {
>  	struct task_struct *p = current;
>  	unsigned long flags;
>  	int dest_cpu;
> +	int ret;
> +
> +	/* this may change what tasks current can share a core with */
> +	ret = sched_core_exec();
> +	if (ret)
> +		return ret;

Did the hunk for fs/exec.c go missing?