linux-kernel - Re: [PATCH 2/3] arm64: dts: qcom: sm8150: add iommus to qups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ab5b7df-1624-10bf-f268-c32dc5bf0bb6@connolly.tech>
Date:   Sat, 20 Mar 2021 17:16:45 +0000
From:   Caleb Connolly <caleb@...nolly.tech>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8150: add iommus to qups

Hi Vinod,

On 16/03/2021 6:15 am, Vinod Koul wrote:
> On 10-03-21, 16:31, Caleb Connolly wrote:
>> Hook up the SMMU for doing DMA over i2c. Some peripherals like
>> touchscreens easily exceed 32-bytes per transfer, causing errors and
>> lockups without this.
> Why not squash this to patch 1..?

I thought it made more sense to separate these patches to keep the 
history a bit cleaner. I can squash them if you'd prefer.

     Caleb

>
>> Signed-off-by: Caleb Connolly <caleb@...nolly.tech>
>> ---
>> Fixes i2c on the OnePlus 7, without this touching the screen with more
>> than 4 fingers causes the device to lock up and reboot.
>> ---
>>   arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index 03e05d98daf2..543417d74216 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -583,6 +583,7 @@ qupv3_id_0: geniqup@...000 {
>>   			clock-names = "m-ahb", "s-ahb";
>>   			clocks = <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>,
>>   				 <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>;
>> +			iommus = <&apps_smmu 0xc3 0x0>;
>>   			#address-cells = <2>;
>>   			#size-cells = <2>;
>>   			ranges;
>> @@ -595,6 +596,7 @@ qupv3_id_1: geniqup@...000 {
>>   			clock-names = "m-ahb", "s-ahb";
>>   			clocks = <&gcc GCC_QUPV3_WRAP_1_M_AHB_CLK>,
>>   				 <&gcc GCC_QUPV3_WRAP_1_S_AHB_CLK>;
>> +			iommus = <&apps_smmu 0x603 0x0>;
>>   			#address-cells = <2>;
>>   			#size-cells = <2>;
>>   			ranges;
>> @@ -617,6 +619,7 @@ qupv3_id_2: geniqup@...000 {
>>   			clock-names = "m-ahb", "s-ahb";
>>   			clocks = <&gcc GCC_QUPV3_WRAP_2_M_AHB_CLK>,
>>   				 <&gcc GCC_QUPV3_WRAP_2_S_AHB_CLK>;
>> +			iommus = <&apps_smmu 0x7a3 0x0>;
>>   			#address-cells = <2>;
>>   			#size-cells = <2>;
>>   			ranges;
>> --
>> 2.29.2
>>
> --
> ~Vinod