linux-kernel - Re: [PATCH] proc: delete redundant subset=pid check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 Mar 2021 19:02:14 +0100
From:   Alexey Gladkov <gladkov.alexey@...il.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: delete redundant subset=pid check

On Sat, Mar 20, 2021 at 06:46:08PM +0300, Alexey Dobriyan wrote:
> Two checks in lookup and readdir code should be enough to not have
> third check in open code.
> 
> Can't open what can't be looked up?

As far as I remember, I first added pidonly processing here and later then
I disabled lookup. Now this is unnecessary.

Acked-by: Alexey Gladkov <gladkov.alexey@...il.com>

> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  fs/proc/inode.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -483,7 +483,6 @@ proc_reg_get_unmapped_area(struct file *file, unsigned long orig_addr,
>  
>  static int proc_reg_open(struct inode *inode, struct file *file)
>  {
> -	struct proc_fs_info *fs_info = proc_sb_info(inode->i_sb);
>  	struct proc_dir_entry *pde = PDE(inode);
>  	int rv = 0;
>  	typeof_member(struct proc_ops, proc_open) open;
> @@ -497,9 +496,6 @@ static int proc_reg_open(struct inode *inode, struct file *file)
>  		return rv;
>  	}
>  
> -	if (fs_info->pidonly == PROC_PIDONLY_ON)
> -		return -ENOENT;
> -
>  	/*
>  	 * Ensure that
>  	 * 1) PDE's ->release hook will be called no matter what
> 

-- 
Rgrds, legion