linux-kernel - Re: [PATCH v3 2/2] mfd: sy7636a: Initial commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f40beda-c72c-5eb-61e3-37213c7c4c42@infradead.org>
Date:   Sun, 21 Mar 2021 10:38:14 -0700 (PDT)
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alistair Francis <alistair@...stair23.me>
cc:     lee.jones@...aro.org, robh+dt@...nel.org, lgirdwood@...il.com,
        broonie@...nel.org, linux-imx@....com, kernel@...gutronix.de,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        alistair23@...il.com
Subject: Re: [PATCH v3 2/2] mfd: sy7636a: Initial commit


Hi,


On Sun, 21 Mar 2021, Alistair Francis wrote:

> Initial support for the Silergy SY7636A Power Management chip.
>
> Signed-off-by: Alistair Francis <alistair@...stair23.me>
> ---
> v3:
> - Address comments in V2
> - Drop regulator patches
>
> drivers/mfd/Kconfig         |  10 ++
> drivers/mfd/Makefile        |   1 +
> drivers/mfd/sy7636a.c       | 246 ++++++++++++++++++++++++++++++++++++
> include/linux/mfd/sy7636a.h |  46 +++++++
> 4 files changed, 303 insertions(+)
> create mode 100644 drivers/mfd/sy7636a.c
> create mode 100644 include/linux/mfd/sy7636a.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index b74efa469e90..a285d11d5be3 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1351,6 +1351,16 @@ config MFD_SYSCON
> 	  Select this option to enable accessing system control registers
> 	  via regmap.
>
> +config MFD_SY7636A
> +	tristate "Silergy SY7636A Power Management chip"
> +	select MFD_CORE
> +	select REGMAP_I2C
> +	select REGMAP_IRQ
> +	depends on I2C=y

So why is this driver tristate but depends on I2C=y?
That's a little confusing.

Thanks.

> +	help
> +	  Select this option to enable support for the Silergy SY7636A
> +	  Power Management chip.