linux-kernel - Re: [PATCH] sched/fair: bring back select_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdf9d6bc50200e5b955b7ff77a8046e1ea09c284.camel@surriel.com>
Date:   Sun, 21 Mar 2021 14:58:27 -0400
From:   Rik van Riel <riel@...riel.com>
To:     Mel Gorman <mgorman@...hsingularity.net>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...com,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Valentin Schneider <valentin.schneider@....com>
Subject: Re: [PATCH] sched/fair: bring back select_idle_smt, but differently

On Sun, 2021-03-21 at 14:48 -0400, Rik van Riel wrote:
> 
> +	if (cpus_share_cache(prev, target)) {
> +		/* No idle core. Check if prev has an idle sibling. */
> +		i = select_idle_smt(p, sd, prev);

Uh, one minute. This is the wrong version of the patch.

There's supposed to be a !smt && in there as well. I first
merged it right, then somehow git ate it, and I merged it
wrong the second time. Sigh.

-- 
All Rights Reversed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)