linux-kernel - Re: [PATCH] drm/tilcdc: panel: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0c5ff308f0bc71b847c805851a6f727c@iki.fi>
Date:   Sun, 21 Mar 2021 21:10:36 +0200
From:   Jyri Sarha <jyri.sarha@....fi>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     tomba@...nel.org, airlied@...ux.ie, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tilcdc: panel: fix platform_no_drv_owner.cocci
 warnings

On 2021-03-03 11:04, Yang Li wrote:
> ./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner
> here. The core will do it.
> 
> Remove .owner field if calls are used which set it automatically
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Reviewed-by: Jyri Sarha <jyri.sarha@....fi>

I'll merge this soon to drm-misc-next.

Best regards,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 00efc30..4235780 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -399,7 +399,6 @@ static int panel_remove(struct platform_device 
> *pdev)
>  	.probe = panel_probe,
>  	.remove = panel_remove,
>  	.driver = {
> -		.owner = THIS_MODULE,
>  		.name = "tilcdc-panel",
>  		.of_match_table = panel_of_match,
>  	},