linux-kernel - Re: [PATCH] KVM: x86: A typo fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210321225428.GA1885130@gmail.com>
Date:   Sun, 21 Mar 2021 23:54:28 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Randy Dunlap <rdunlap@...badil.infradead.org>
Cc:     Bhaskar Chowdhury <unixbhaskar@...il.com>, pbonzini@...hat.com,
        seanjc@...gle.com, vkuznets@...hat.com, wanpengli@...cent.com,
        jmattson@...gle.com, joro@...tes.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, x86@...nel.org, hpa@...or.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: A typo fix


* Randy Dunlap <rdunlap@...badil.infradead.org> wrote:

> 
> 
> On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:
> 
> > 
> > s/resued/resumed/
> > 
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> 
> 
> > ---
> > arch/x86/include/asm/kvm_host.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> > index 9bc091ecaaeb..eae82551acb1 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
> > /*
> >  * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
> >  *			userspace I/O) to indicate that the emulation context
> > - *			should be resued as is, i.e. skip initialization of
> > + *			should be resumed as is, i.e. skip initialization of
> >  *			emulation context, instruction fetch and decode.

This is the *wrong* fix, the correct word in this context is 'reused', 
not 'resumed' ...

See how I fixed most arch/x86/ typo fixes in tip:x86/cleanups:

  d9f6e12fb0b7: ("x86: Fix various typos in comments")
  163b099146b8: ("x86: Fix various typos in comments, take #2")

These single file typo fixes are a bad idea for another reason as 
well, as they create a lot of unnecessary churn.

Thanks,

	Ingo