linux-kernel - [PATCH] sound: soc: sh: fix Kconfig dependency on DMADEVICES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 21 Mar 2021 19:19:19 -0400
From:   Julian Braha <julianbraha@...il.com>
To:     broonie@...nel.org
Cc:     linux-kernel@...r.kernel.org, fazilyildiran@...il.com
Subject: [PATCH] sound: soc: sh: fix Kconfig dependency on DMADEVICES

When SND_SIU_MIGOR is enabled, and DMADEVICES is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for SND_SOC_SH4_SIU
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (SUPERH [=y] || ARCH_RENESAS || COMPILE_TEST [=n]) && ARCH_SHMOBILE [=y] && HAVE_CLK [=y] && DMADEVICES [=n]
  Selected by [y]:
  - SND_SIU_MIGOR [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (SUPERH [=y] || ARCH_RENESAS || COMPILE_TEST [=n]) && SH_MIGOR [=y] && I2C [=y]

This is because SND_SIU_MIGOR selects SND_SOC_SH4_SIU
without selecting or depending on DMADEVICES,
despite SND_SOC_SH4_SIU depending on DMADEVICES.

Signed-off-by: Julian Braha <julianbraha@...il.com>
---
 sound/soc/sh/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig
index 346c806ba390..503ee235e46d 100644
--- a/sound/soc/sh/Kconfig
+++ b/sound/soc/sh/Kconfig
@@ -60,7 +60,7 @@ config SND_SH7760_AC97
 
 config SND_SIU_MIGOR
 	tristate "SIU sound support on Migo-R"
-	depends on SH_MIGOR && I2C
+	depends on SH_MIGOR && I2C && DMADEVICES
 	select SND_SOC_SH4_SIU
 	select SND_SOC_WM8978
 	help
-- 
2.25.1