linux-kernel - Re: [PATCH] media/pci: Assign value when defining variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47a40a03-2b54-3cb6-9314-060457794882@xs4all.nl>
Date:   Sun, 21 Mar 2021 10:19:34 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     zuoqilin1@....com, tskd08@...il.com, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        zuoqilin <zuoqilin@...ong.com>
Subject: Re: [PATCH] media/pci: Assign value when defining variables

Hi zuoqilin,

On 17/03/2021 04:08, zuoqilin1@....com wrote:
> From: zuoqilin <zuoqilin@...ong.com>
> 
> When defining variables and assigning values can be done at the same time.

For future reference: add the name of the driver to the prefix. Saying
'media/pci:' suggests that you patch multiple PCI drivers in that directory.
But 'media/pci/pt1:' indicates that you patch only the pt1 driver.

I've updated the subject, so no need to repost, but remember this for next
time :-)

Regards,

	Hans

> 
> Signed-off-by: zuoqilin <zuoqilin@...ong.com>
> ---
>  drivers/media/pci/pt1/pt1.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c
> index 72b191c..f2aa368 100644
> --- a/drivers/media/pci/pt1/pt1.c
> +++ b/drivers/media/pci/pt1/pt1.c
> @@ -334,8 +334,7 @@ static int pt1_sync(struct pt1 *pt1)
>  static u64 pt1_identify(struct pt1 *pt1)
>  {
>  	int i;
> -	u64 id;
> -	id = 0;
> +	u64 id = 0;
>  	for (i = 0; i < 57; i++) {
>  		id |= (u64)(pt1_read_reg(pt1, 0) >> 30 & 1) << i;
>  		pt1_write_reg(pt1, 0, 0x00000008);
> @@ -1122,8 +1121,7 @@ static int pt1_i2c_end(struct pt1 *pt1, int addr)
>  
>  static void pt1_i2c_begin(struct pt1 *pt1, int *addrp)
>  {
> -	int addr;
> -	addr = 0;
> +	int addr = 0;
>  
>  	pt1_i2c_emit(pt1, addr,     0, 0, 1, 1, addr /* itself */);
>  	addr = addr + 1;
>