linux-kernel - Re: [PATCH 1/2] Input: wacom_i2c - do not force interrupt trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Mar 2021 09:13:15 -0400
From:   Alistair <alistair@...stair23.me>
To:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Cc:     "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Input: wacom_i2c - do not force interrupt trigger

On Sun, Mar 21, 2021, at 6:00 PM, Dmitry Torokhov wrote:
> Instead of forcing interrupt trigger to "level low" rely on the
> platform to set it up according to how it is wired on the given
> board.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com <mailto:dmitry.torokhov%40gmail.com>>

Reviewed-by: Alistair Francis <alistair@...stair23.me>

Alistair

> ---
> drivers/input/touchscreen/wacom_i2c.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/wacom_i2c.c b/drivers/input/touchscreen/wacom_i2c.c
> index 1afc6bde2891..609ff84e7693 100644
> --- a/drivers/input/touchscreen/wacom_i2c.c
> +++ b/drivers/input/touchscreen/wacom_i2c.c
> @@ -195,8 +195,7 @@ static int wacom_i2c_probe(struct i2c_client *client,
> input_set_drvdata(input, wac_i2c);
>  
> error = request_threaded_irq(client->irq, NULL, wacom_i2c_irq,
> -      IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> -      "wacom_i2c", wac_i2c);
> +      IRQF_ONESHOT, "wacom_i2c", wac_i2c);
> if (error) {
> dev_err(&client->dev,
> "Failed to enable IRQ, error: %d\n", error);
> -- 
> 2.31.0.rc2.261.g7f71774620-goog
> 
>