linux-kernel - Re: [PATCH] fs/fuse: Fix matching of FUSE_DEV_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegsovR6i6tVOzTPP8V8Y9PxmtRx5M+=2Z9oKMcpYO3Dd2Q@mail.gmail.com>
Date:   Mon, 22 Mar 2021 16:04:48 +0100
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Alessio Balsini <balsini@...roid.com>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        kernel-team <kernel-team@...roid.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/fuse: Fix matching of FUSE_DEV_IOC_CLONE command

On Fri, Mar 19, 2021 at 4:06 PM Alessio Balsini <balsini@...roid.com> wrote:
>
> With commit f8425c939663 ("fuse: 32-bit user space ioctl compat for fuse
> device") the matching constraints for the FUSE_DEV_IOC_CLONE ioctl
> command are relaxed, limited to the testing of command type and number.
> As Arnd noticed, this is wrong as it wouldn't ensure the correctness of
> the data size or direction for the received FUSE device ioctl.
>
> Fix by bringing back the comparison of the ioctl received by the FUSE
> device to the originally generated FUSE_DEV_IOC_CLONE.
>
> Fixes: f8425c939663 ("fuse: 32-bit user space ioctl compat for fuse device")
> Reported-by: Arnd Bergmann <arnd@...nel.org>
> Signed-off-by: Alessio Balsini <balsini@...roid.com>

Thanks, applied.   I'm holding this till the 5.13 merge window unless
a more series fuse issue emerges in the meantime

Thanks,
Miklos