linux-kernel - Re: [Linux-stm32] [PATCH v10 11/33] counter: stm32-timer-cnt: Add const qualifier for functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3a958a4-103c-59a3-6716-47f8167c59d6@foss.st.com>
Date:   Mon, 22 Mar 2021 17:22:49 +0100
From:   Fabrice Gasnier <fabrice.gasnier@...s.st.com>
To:     William Breathitt Gray <vilhelm.gray@...il.com>, <jic23@...nel.org>
CC:     Benjamin Gaignard <benjamin.gaignard@...com>,
        <kamel.bouhara@...tlin.com>, <gwendal@...omium.org>,
        <david@...hnology.com>, <linux-iio@...r.kernel.org>,
        <patrick.havelange@...ensium.com>, <alexandre.belloni@...tlin.com>,
        <mcoquelin.stm32@...il.com>, <linux-kernel@...r.kernel.org>,
        <o.rempel@...gutronix.de>, <kernel@...gutronix.de>,
        <fabrice.gasnier@...com>, <syednwaris@...il.com>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <alexandre.torgue@...com>
Subject: Re: [Linux-stm32] [PATCH v10 11/33] counter: stm32-timer-cnt: Add
 const qualifier for functions_list array

On 3/19/21 12:00 PM, William Breathitt Gray wrote:
> The struct counter_count functions_list member expects a const enum
> counter_count_function array. This patch adds the const qualifier to the
> stm32_count_functions to match functions_list.
> 
> Cc: Fabrice Gasnier <fabrice.gasnier@...com>
> Cc: Benjamin Gaignard <benjamin.gaignard@...com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> ---
>  drivers/counter/stm32-timer-cnt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi William,

You can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>

Thanks,
Fabrice

> 
> diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
> index 75bc401fdd18..0c18573a7837 100644
> --- a/drivers/counter/stm32-timer-cnt.c
> +++ b/drivers/counter/stm32-timer-cnt.c
> @@ -50,7 +50,7 @@ enum stm32_count_function {
>  	STM32_COUNT_ENCODER_MODE_3,
>  };
>  
> -static enum counter_count_function stm32_count_functions[] = {
> +static const enum counter_count_function stm32_count_functions[] = {
>  	[STM32_COUNT_SLAVE_MODE_DISABLED] = COUNTER_COUNT_FUNCTION_INCREASE,
>  	[STM32_COUNT_ENCODER_MODE_1] = COUNTER_COUNT_FUNCTION_QUADRATURE_X2_A,
>  	[STM32_COUNT_ENCODER_MODE_2] = COUNTER_COUNT_FUNCTION_QUADRATURE_X2_B,
>