linux-kernel - Re: [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFjJ/fpe8acRxeN5@google.com>
Date:   Mon, 22 Mar 2021 09:46:53 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Chris Goldsworthy <cgoldswo@...eaurora.org>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>, joaodias@...gle.com,
        surenb@...gle.com, mhocko@...e.com, david@...hat.com,
        vbabka@...e.cz, linux-fsdevel@...r.kernel.org,
        oliver.sang@...el.com
Subject: Re: [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration

On Sat, Mar 20, 2021 at 03:51:40PM -0700, Chris Goldsworthy wrote:
> On 2021-03-20 12:54, Matthew Wilcox wrote:
> > On Sat, Mar 20, 2021 at 10:20:09AM -0700, Minchan Kim wrote:
> > > > > Tested-by: Oliver Sang <oliver.sang@...el.com>
> > > > > Reported-by: kernel test robot <oliver.sang@...el.com>
> > > > > Signed-off-by: Chris Goldsworthy <cgoldswo@...eaurora.org>
> > > > > Signed-off-by: Minchan Kim <minchan@...nel.org>
> > > >
> > > > The signoff chain ordering might mean that Chris was the primary author, but
> > > > there is no From:him.  Please clarify?
> > > 
> > > He tried first version but was diffrent implementation since I
> > > changed a lot. That's why I added his SoB even though current
> > > implementaion is much different. So, maybe I am primary author?
> 
> Hey Minchan, let's have you as the primary author.
> 
> > Maybe Chris is Reported-by: ?  And don't forget Laura Abbott as original
> > author of the patch Chris submitted.  I think she should be Reported-by:
> > as well, since there is no code from either of them in this version of
> > the patch.
> 
> Yes, let's have a Reported-by: from Laura. We can change my Signed-off-by to
> Reported-by: as well.

Thanks Matthew and Chris.

I just wanted to give more credit(something like Co-authored-by if we have
such kinds of tag) to Chris since I felt he had more than. :)

Okay, let's have something like this.

From: Minchan Kim <minchan@...nel.org>

..

Tested-by: Oliver Sang <oliver.sang@...el.com>
Reported-by: kernel test robot <oliver.sang@...el.com>
Reported-by: Laura Abbott <lauraa@...eaurora.org>
Reported-by: Chris Goldsworthy <cgoldswo@...eaurora.org>
Signed-off-by: Minchan Kim <minchan@...nel.org>

Andrew, if you want me resend the patch, let me know.

Thank you.