linux-kernel - Re: [PATCH v2] dt-binding: leds: Document leds-multi-gpio bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Mar 2021 11:38:18 -0600
From:   Rob Herring <robh@...nel.org>
To:     Hermes Zhang <chenhui.zhang@...s.com>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, kernel@...s.com,
        linux-kernel@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        Hermes Zhang <chenhuiz@...s.com>, linux-leds@...r.kernel.org
Subject: Re: [PATCH v2] dt-binding: leds: Document leds-multi-gpio bindings

On Mon, 22 Mar 2021 17:18:19 +0800, Hermes Zhang wrote:
> From: Hermes Zhang <chenhuiz@...s.com>
> 
> Document the device tree bindings of the multiple GPIOs LED driver
> Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml.
> 
> Signed-off-by: Hermes Zhang <chenhuiz@...s.com>
> ---
> 
> Notes:
>     Fix typo and missing item
> 
>  .../bindings/leds/leds-multi-gpio.yaml        | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-multi-gpio.example.dt.yaml: gpios-led: led-states: 'oneOf' conditional failed, one must be fixed:
	[[0, 1, 2, 3]] is too short
	[0, 1, 2, 3] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml

See https://patchwork.ozlabs.org/patch/1456433

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.