linux-kernel - Re: [PATCH net-next 3/6] page_pool: DMA handling and allow to recycles frames via SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFnufp0t3EzB=kSbCFax4b=TNbvPp=JS1PaZAzM5F4-RfoCbRQ@mail.gmail.com>
Date:   Mon, 22 Mar 2021 20:38:40 +0100
From:   Matteo Croce <mcroce@...ux.microsoft.com>
To:     netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Saeed Mahameed <saeedm@...dia.com>,
        David Ahern <dsahern@...il.com>,
        Saeed Mahameed <saeed@...nel.org>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next 3/6] page_pool: DMA handling and allow to
 recycles frames via SKB

On Mon, Mar 22, 2021 at 6:03 PM Matteo Croce <mcroce@...ux.microsoft.com> wrote:
>
> From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
>
> During skb_release_data() intercept the packet and if it's a buffer
> coming from our page_pool API recycle it back to the pool for further
> usage.
> To achieve that we introduce a bit in struct sk_buff (pp_recycle:1) and
> store the xdp_mem_info in page->private. The SKB bit is needed since
> page->private is used by skb_copy_ubufs, so we can't rely solely on
> page->private to trigger recycling.
>
> The driver has to take care of the sync operations on it's own
> during the buffer recycling since the buffer is never unmapped.
>
> In order to enable recycling the driver must call skb_mark_for_recycle()
> to store the information we need for recycling in page->private and
> enabling the recycling bit
>
> Storing the information in page->private allows us to recycle both SKBs
> and their fragments
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Signed-off-by: Matteo Croce <mcroce@...rosoft.com>
> ---

Hi, the patch title really should be:

page_pool: DMA handling and frame recycling via SKBs

As in the previous RFC.
Sorry,
-- 
per aspera ad upstream