linux-kernel - RE: [PATCH] usb: cdns3: delete repeated clear operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR07MB5381E439E54E87C91086BA07DD659@BYAPR07MB5381.namprd07.prod.outlook.com>
Date:   Mon, 22 Mar 2021 07:19:46 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     "peter.chen@...nel.org" <peter.chen@...nel.org>,
        Wang Qing <wangqing@...o.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: cdns3: delete repeated clear operations

Hi Peter,

Can you add this patch to for-usb-next branch.

Thanks.

>
>
>dma_alloc_coherent already zeroes out memory, so memset is not needed.
>
>Signed-off-by: Wang Qing <wangqing@...o.com>

Reviewed-by: Pawel Laszczak <pawell@...ence.com>

>---
> drivers/usb/cdns3/cdnsp-mem.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c
>index 7a84e92..1d1b9a4
>--- a/drivers/usb/cdns3/cdnsp-mem.c
>+++ b/drivers/usb/cdns3/cdnsp-mem.c
>@@ -1231,7 +1231,6 @@ int cdnsp_mem_init(struct cdnsp_device *pdev)
> 	if (!pdev->dcbaa)
> 		return -ENOMEM;
>
>-	memset(pdev->dcbaa, 0, sizeof(*pdev->dcbaa));
> 	pdev->dcbaa->dma = dma;
>
> 	cdnsp_write_64(dma, &pdev->op_regs->dcbaa_ptr);
>--
>2.7.4

Regards,
Pawel Laszczak