linux-kernel - Re: [PATCH 5.10 267/290] powerpc: Fix missing declaration of [en/dis]able_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFhSLhW5Hy2MeVVx@kroah.com>
Date:   Mon, 22 Mar 2021 09:15:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 5.10 267/290] powerpc: Fix missing declaration of
 [en/dis]able_kernel_vsx()

On Mon, Mar 22, 2021 at 07:16:25AM +0100, Christophe Leroy wrote:
> 
> 
> Le 15/03/2021 à 15:15, Geert Uytterhoeven a écrit :
> > On Mon, Mar 15, 2021 at 3:04 PM <gregkh@...uxfoundation.org> wrote:
> > > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > 
> > > From: Christophe Leroy <christophe.leroy@...roup.eu>
> > > 
> > > commit bd73758803c2eedc037c2268b65a19542a832594 upstream.
> > > 
> > > Add stub instances of enable_kernel_vsx() and disable_kernel_vsx()
> > > when CONFIG_VSX is not set, to avoid following build failure.
> > 
> > Please note that this is not sufficient, and will just turn the build error
> > in another, different build error.
> 
> Not exactly, the fix is sufficient in most case, it is only with ancient
> versions of gcc (eg 4.9) or with CONFIG_CC_OPTIMISE_FOR_SIZE that we now get
> a build bug. Building with gcc 10 now works.
> 
> > Waiting for the subsequent fix to enter v5.12-rc4...
> > https://lore.kernel.org/lkml/2c123f94-ceae-80c0-90e2-21909795eb76@csgroup.eu/
> 
> This has now landed in mainline as commit
> eed5fae00593ab9d261a0c1ffc1bdb786a87a55a see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/powerpc/include/asm/cpu_has_feature.h?h=v5.12-rc4&id=eed5fae00593ab9d261a0c1ffc1bdb786a87a55a

Now queued up, thanks.

greg k-h