linux-kernel - Re: [PATCH] crypto: atmel-ecc - fix W=1 "cannot understand" warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc9ca7d7-a3eb-a756-0d8d-5fd06de24fe7@microchip.com>
Date:   Mon, 22 Mar 2021 09:11:55 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <yumeng18@...wei.com>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>
CC:     <linux-crypto@...r.kernel.org>, <xuzaibo@...wei.com>,
        <wangzhou1@...ilicon.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: atmel-ecc - fix W=1 "cannot understand" warning

On 3/20/21 10:15 AM, Meng Yu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Fix kernel-doc warnings due to missing "struct" keyword.
> 
> The warning likes:
> drivers/crypto/atmel-ecc.c:40: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx '
> 
> Signed-off-by: Meng Yu <yumeng18@...wei.com>

Thanks. There is a patch similar to yours that was sent in advance:
https://patchwork.kernel.org/project/linux-crypto/patch/20210318124422.3200180-7-lee.jones@linaro.org/

> ---
>  drivers/crypto/atmel-ecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 515946c..333fbef 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -26,7 +26,7 @@
>  static struct atmel_ecc_driver_data driver_data;
> 
>  /**
> - * atmel_ecdh_ctx - transformation context
> + * struct atmel_ecdh_ctx - transformation context
>   * @client     : pointer to i2c client device
>   * @fallback   : used for unsupported curves or when user wants to use its own
>   *               private key.
> --
> 2.8.1
>