linux-kernel - Re: [PATCH v6 1/8] mm: Remove special swap entry functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13488904.3iE9EkMCc7@nvdebian>
Date:   Mon, 22 Mar 2021 20:20:05 +1100
From:   Alistair Popple <apopple@...dia.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     <linux-mm@...ck.org>, <nouveau@...ts.freedesktop.org>,
        <bskeggs@...hat.com>, <akpm@...ux-foundation.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kvm-ppc@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <jhubbard@...dia.com>, <rcampbell@...dia.com>,
        <jglisse@...hat.com>, <jgg@...dia.com>, <daniel@...ll.ch>,
        <willy@...radead.org>
Subject: Re: [PATCH v6 1/8] mm: Remove special swap entry functions

On Monday, 15 March 2021 6:27:57 PM AEDT Christoph Hellwig wrote:
> On Fri, Mar 12, 2021 at 07:38:44PM +1100, Alistair Popple wrote:
> > Remove the migration and device private entry_to_page() and
> > entry_to_pfn() inline functions and instead open code them directly.
> > This results in shorter code which is easier to understand.
> 
> I think this commit log should mention pfn_swap_entry_to_page() now.

Will add. Thanks for the review.

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
>