linux-kernel - Re: [PATCH 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efd21696-fb2b-e466-21fc-9b4cca40ffc1@huawei.com>
Date:   Mon, 22 Mar 2021 09:52:12 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Rafael Aquini <aquini@...hat.com>
CC:     <akpm@...ux-foundation.org>, <jglisse@...hat.com>,
        <shy828301@...il.com>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>
Subject: Re: [PATCH 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on
 putback_movable_page()

Hi:
On 2021/3/20 22:11, Rafael Aquini wrote:
> On Sat, Mar 20, 2021 at 05:36:57AM -0400, Miaohe Lin wrote:
>> The !PageLocked() check is implicitly done in PageMovable(). Remove this
>> explicit one.
>>
> 
> I'd just keep the explicit assertion in place, regardless.
> But if you're going to stick with this patch, please fix it because it's 
> removing the wrong assertion.

Many thanks for your reply. I should have a coffee when I make this patch! :(
Will fix it. Many thanks for remind!

> 
> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>>  mm/migrate.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index 47df0df8f21a..e4ca5ef508ea 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -146,7 +146,6 @@ void putback_movable_page(struct page *page)
>>  	struct address_space *mapping;
>>  
>>  	VM_BUG_ON_PAGE(!PageLocked(page), page);
>> -	VM_BUG_ON_PAGE(!PageMovable(page), page);
>>  	VM_BUG_ON_PAGE(!PageIsolated(page), page);
>>  
>>  	mapping = page_mapping(page);
>> -- 
>> 2.19.1
>>
>>
> 
> .
>