linux-kernel - Re: sched: allow resubmits to queue_balance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFh0QjnoGPmbykyE@hirez.programming.kicks-ass.net>
Date:   Mon, 22 Mar 2021 11:41:06 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Barret Rhoden <brho@...gle.com>
Cc:     Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: sched: allow resubmits to queue_balance_callback()

On Thu, Mar 18, 2021 at 03:57:34PM -0400, Barret Rhoden wrote:
> Prior to this commit, if you submitted the same callback_head twice, it
> would be enqueued twice, but only if it was the last callback on the
> list.  The first time it was submitted, rq->balance_callback was NULL,
> so head->next is NULL.  That defeated the check in
> queue_balance_callback().
> 
> This commit changes the callback list such that whenever an item is on
> the list, its head->next is not NULL.  The last element (first inserted)
> will point to itself.  This allows us to detect and ignore any attempt
> to reenqueue a callback_head.
> 
> Signed-off-by: Barret Rhoden <brho@...gle.com>

AFAICT you're patching dead code, please check a current tree.