[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAE+NS37XOgRotVTBLeFtbLYEksRydOLBHdCfMH9fTFNZ5J+2Dw@mail.gmail.com>
Date: Mon, 22 Mar 2021 18:54:23 +0800
From: Gene Chen <gene.chen.richtek@...il.com>
To: Pavel Machek <pavel@....cz>
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Dan Murphy <dmurphy@...com>,
Linux LED Subsystem <linux-leds@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Gene Chen <gene_chen@...htek.com>, Wilma.Wu@...iatek.com,
shufan_lee@...htek.com, ChiYuan Huang <cy_huang@...htek.com>,
benjamin.chao@...iatek.com
Subject: Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
Gene Chen <gene.chen.richtek@...il.com> 於 2021年3月2日 週二 下午2:08寫道:
>
> Pavel Machek <pavel@....cz> 於 2021年2月19日 週五 下午6:47寫道:
> >
> > Hi!
> >
> > > From: Gene Chen <gene_chen@...htek.com>
> > >
> > > Add LED_FUNCTION_MOONLIGHT definitions
> > >
> > > Signed-off-by: Gene Chen <gene_chen@...htek.com>
> > > Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> > > Acked-by: Rob Herring <robh@...nel.org>
> >
> > No, sorry, I don't believe we need another define for flash/torch.
> >
>
> As previous discuss,
> > We use term "Moonlight" as reference says
> > "When you are trying to imitate moonlight you need to use low voltage,
> > softer lighting. You don’t want something that’s too bright"
> > which is focus on brightness instead of color.
>
> If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead?
> (refs: https://lkml.org/lkml/2020/11/24/1267)
Is there any update?
> > Best regards,
> > Pavel
> > --
> > http://www.livejournal.com/~pavelmachek
Powered by blists - more mailing lists