linux-kernel - Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Mar 2021 13:02:04 +0200
From:   Eli Billauer <eli.billauer@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     arnd@...db.de, devel@...verdev.osuosl.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        dan.carpenter@...cle.com
Subject: Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to
 new xillybus_class.c

On 21/03/21 14:24, Greg KH wrote:
>> +config XILLYBUS_CLASS
>> >  +	tristate
>> >  +
>> >    config XILLYBUS
>> >    	tristate "Xillybus generic FPGA interface"
>> >    	depends on PCI || OF
>> >    	select CRC32
>> >  +	select XILLYBUS_CLASS
>>      
> depends on, do not select.
>
>    
XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux 
distributions. Making them depend on, rather than select XILLYBUS_CLASS 
is likely to disable the driver in those distributions.

With "select", "make oldconfig" sets XILLYBUS_CLASS to the correct value 
smoothly and silently.

Besides, isn't this the intended use case for "select"? A config symbol 
that doesn't depend on anything else, and solves a technical need to 
compile Y if X is enabled?

Or is there a way to use "depends on" without this problem?

Regards,
    Eli