linux-kernel - Re: [PATCH] sound: remove unnecessary blank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h35wne8gc.wl-tiwai@suse.de>
Date:   Mon, 22 Mar 2021 12:25:39 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Fengfei Xi <xi.fengfei@....com>
Cc:     <perex@...ex.cz>, <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: remove unnecessary blank

On Sun, 21 Mar 2021 09:59:48 +0100,
Fengfei Xi wrote:
> 
> Remove unnecessary blank when calling kmalloc_array().
> 
> Signed-off-by: Fengfei Xi <xi.fengfei@....com>

Thanks for the patch.

We apply this kind of trivial coding-style fix only if it'd improve
the readability significantly or when it's a preliminary work for the
other actual fixes.  So if you'd work on this driver further, let us
know.


Takashi

> ---
>  sound/oss/dmasound/dmasound_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
> index 49679aa86..78bb9dfe2 100644
> --- a/sound/oss/dmasound/dmasound_core.c
> +++ b/sound/oss/dmasound/dmasound_core.c
> @@ -421,7 +421,7 @@ static int sq_allocate_buffers(struct sound_queue *sq, int num, int size)
>  		return 0;
>  	sq->numBufs = num;
>  	sq->bufSize = size;
> -	sq->buffers = kmalloc_array (num, sizeof(char *), GFP_KERNEL);
> +	sq->buffers = kmalloc_array(num, sizeof(char *), GFP_KERNEL);
>  	if (!sq->buffers)
>  		return -ENOMEM;
>  	for (i = 0; i < num; i++) {
> -- 
> 2.17.1
>